v1.4 Form Designer New Toolbar bugs

[Steven Kang]

The form designer is shaping up nicely with the addition of the new toolbar. Inevitably, a number of bugs / ommissions have slipped through with the first release of the code: 1. None of the toolbar icons update to reflect the properties of the selected control; they just remain in their pre-control-selected state. 2. The actions of the text alignment controls need to be made conditional on the selected control being a “Text” or “Editable Text” control. Mistakenly applying them to any other control (e.g. Pushbutton text, option button text etc) or even a graphic, causes Personal to crash and quit. 3. The Font Size Combo droplist opens and closes immediately making it impossible to make a selection. Sometimes this only happens if no contol is selected and other times even if a control is selected. 4. The Bold, Italic and Underline icons all have the same incorrect tooltip (“Draw a push button”). 5. The Background and Foreground Color icons deserve some tooltips as it is not immediately clear that the two with text on them open up the Colour Picker dialogs (but do not apply the colour to any selected controls) whilst the other two not only display the selected colour but need to be clicked to apply the colour to any selected controls. Steven

[Michael]

On 10/10/2010 15:46, Steven Kang wrote:
> The form designer is shaping up nicely with the addition of the new
> toolbar.
>
> Inevitably, a number of bugs / ommissions have slipped through with
> the first release of the code:
>
> 1. None of the toolbar icons update to reflect the properties of the
> selected control; they just remain in their pre-control-selected
> state.

That is true. It is actually a design decision currently. The problem
has to do with deciding where what causes the global state to change. It
may be that if you click on the page I could set them to the global
state. At the moment, the toolbar always reflects the global settings.
The real problem arises when you click on more than one control. What
should the toolbar do if the two controls do not have the same settings?

> 2. The actions of the text alignment controls need to be made
> conditional on the selected control being a "Text" or "Editable Text"
> control. Mistakenly applying them to any other control (e.g.
> Pushbutton text, option button text etc) or even a graphic, causes
> Personal to crash and quit.

Hmm. That shouldn't have happened. I will check the code. It was
supposed to ignore controls that are not text or edittext.

> 3. The Font Size Combo droplist opens and closes immediately making
> it impossible to make a selection. Sometimes this only happens if no
> contol is selected and other times even if a control is selected.

This is actually a problem that still needs to be fixed in the
wxformcombo if you use the dropedit mode. If you click first in the edit
control, then you drop the list it works. The problem has to do with the
fact that in wxWidgets this control is built with two different pieces
and the two pieces are generating individual events rather than acting
as one control.

> 4. The Bold, Italic and Underline icons all have the same incorrect
> tooltip ("Draw a push button").

Ooops. Thanks, will fix that.

> 5. The Background and Foreground Color icons deserve some tooltips as
> it is not immediately clear that the two with text on them open up
> the Colour Picker dialogs (but do not apply the colour to any
> selected controls) whilst the other two not only display the selected
> colour but need to be clicked to apply the colour to any selected
> controls.

Good point. Again, this was a first stab at trying to get a UI that
offers the ability to set the global state and apply it to the controls.
I still intend to add the suck and spit tools that Superbase has.

Ciao, Neil

[Author]

Posts